Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Extension Compatible With Dynamic Property Deprecation in PHP 8.2 #33

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

soleilcot
Copy link
Contributor

PHP 8.2 deprecated the use of Dynamic Properties. This is causing a fatal error and crash in Magento. This PR removes the use of dynamic properties in favor of directly declaring the affected properties in the class.

@soleilcot soleilcot requested a review from samumaretiya August 11, 2023 18:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@samumaretiya samumaretiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good but make sure that it will be well tested on a particular environment after deployment

@soleilcot soleilcot merged commit 92da048 into release/CAB-774 Aug 14, 2023
soleilcot added a commit that referenced this pull request Aug 21, 2023
…HP 8.2 (#33)

* fix: Remove dynamic property to ensure PHP 8.2 compatibility

* fix: Make cron jobs compatible with PHP8.2
@soleilcot soleilcot deleted the fix/PHP8.2_compatibility branch August 21, 2023 16:06
nofraud-automation-bot pushed a commit that referenced this pull request Aug 21, 2023
## [1.0.2](v1.0.1...v1.0.2) (2023-08-21)

### Bug Fixes

* Make Extension Compatible With Dynamic Property Deprecation in PHP 8.2 ([#33](#33)) ([6968aa0](6968aa0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants